calcite icon indicating copy to clipboard operation
calcite copied to clipboard

[CALCITE-3697] Implement BITCOUNT function

Open XuQianJin-Stars opened this issue 5 years ago • 5 comments

As illustrated in CALCITE-3697 select bit_count(8); +--------+ | EXPR$0 | +--------+ | 1 | +--------+ (1 row)

!ok

XuQianJin-Stars avatar Jan 11 '20 04:01 XuQianJin-Stars

Looks great 👍

ritesh-kapoor avatar Jan 12 '20 18:01 ritesh-kapoor

It's just a minor suggestion. This PR LGTM.

DonnyZone avatar Jan 13 '20 06:01 DonnyZone

hi @DonnyZone This PR is OK?

XuQianJin-Stars avatar Mar 15 '20 13:03 XuQianJin-Stars

As Julian's comment in this JIRA, any consensuses on the function's name? I can see a discussion in CALCITE-3732.

DonnyZone avatar Mar 16 '20 01:03 DonnyZone

As Julian's comment in this JIRA, any consensuses on the function's name? I can see a discussion in CALCITE-3732.

Let me change it .

XuQianJin-Stars avatar Mar 16 '20 01:03 XuQianJin-Stars