calcite icon indicating copy to clipboard operation
calcite copied to clipboard

Published 20 hours ago • verified publisher icon apache

CALCITE-3770, minor change "EnumerableCalcRel" appears in code to "EnumerableCalc".

Open Aaaaaaron opened this issue 5 years ago • 6 comments

Is this a typo?

Aaaaaaron avatar Dec 30 '19 03:12 Aaaaaaron

Maybe we can merge it with another pr.

chunweilei avatar Dec 30 '19 09:12 chunweilei

Maybe we can merge it with another pr.

+1

xy2953396112 avatar Dec 30 '19 11:12 xy2953396112

Maybe we can merge it with another pr.

which PR?

Aaaaaaron avatar Dec 30 '19 11:12 Aaaaaaron

Maybe we can merge it with another pr.

which PR?

PR which is not trivial such as bug fix or a feature.

chunweilei avatar Dec 31 '19 02:12 chunweilei

@zabetak OK, thanks a lot, I'll give a look. And one thing I want to for sure, do you think it needs to be modified in history.md? IMHO, we shouldn't.

Aaaaaaron avatar Feb 12 '20 12:02 Aaaaaaron

And one thing I want to for sure, do you think it needs to be modified in history.md? IMHO, we shouldn't.

I agree. Don't change history. It is (basically) a log of commit messages.

julianhyde avatar Feb 12 '20 19:02 julianhyde