calcite icon indicating copy to clipboard operation
calcite copied to clipboard

[CALCITE-2888] Enhance RexImplicationChecker to better handle cast

Open jh3507 opened this issue 6 years ago • 1 comments

  • make RexImplicationChecker use executor's reduce function when generating a value for literal(VisitorDataContext)

  • allow other implementations of RexExecutor

Change-Id: Ie343535c1061d0927356aa37332c048306c5739a

jh3507 avatar Mar 01 '19 18:03 jh3507

-1, I think it's not a good idea to make so muck changes just to move constant reduction logic into RexImplicationChecker, because there is a rule/rules can do this.

Actually for production, the RexExecutor is pluggable for users, so the cast is not much big problem.

danny0405 avatar Mar 02 '19 04:03 danny0405