burr icon indicating copy to clipboard operation
burr copied to clipboard

fix Application.arun's returning type to include [ApplicationStateType]

Open tiejunhu opened this issue 6 months ago • 4 comments

Align with Application.run and fix the type checker issue on calling arun

also add typing information for SyncTrackingClient.clone method

Changes

How I tested this

Notes

Checklist

  • [ ] PR has an informative and human-readable title (this will be pulled into the release notes)
  • [ ] Changes are limited to a single goal (no scope creep)
  • [ ] Code passed the pre-commit check & code is left cleaner/nicer than when first encountered.
  • [ ] Any change in functionality is tested
  • [ ] New functions are documented (with a description, list of inputs, and expected output)
  • [ ] Placeholder code is flagged / future TODOs are captured in comments
  • [ ] Project documentation has been updated if adding/changing functionality.

tiejunhu avatar Jul 01 '25 15:07 tiejunhu

@tiejunhu sorry about this -- @elijahbenizzy why did we never merge this?

skrawcz avatar Nov 24 '25 03:11 skrawcz

@tiejunhu sorry about this -- @elijahbenizzy why did we never merge this?

@tiejunhu @skrawcz race condition -- this had already been fixed (IIRC I just did this): https://github.com/apache/burr/blob/3e58c5804d7682058fb3eaa0a8ae9479da713b05/burr/core/application.py#L1317

elijahbenizzy avatar Nov 24 '25 04:11 elijahbenizzy

Duplicate https://github.com/apache/burr/commit/48db8297b7d216f772f0a46c2f0ab638606484be

thanks @tiejunhu !

elijahbenizzy avatar Nov 24 '25 04:11 elijahbenizzy

I saw this commit has been included in merged PR. So I closed it. No worries.

tiejunhu avatar Nov 25 '25 01:11 tiejunhu