brpc

brpc copied to clipboard

Feature request: Merge RDMA branch into master

1

blockers: * Is RDMA branch stabilized? Any bugs to be solved? * Is code readable enough? * Are unit tests sufficient? Timeline: // TODO

zyearn

用mold链接brpc报duplicate symbol

1

**Describe the bug (描述bug)** 用ld/lld/gold链接都是可以的，但是mold链接就会报这个错，不知道是mold的问题还是brpc的问题？ **To Reproduce (复现方法)** ```cpp mold: error: duplicate symbol: /home/bitetheddddt/dbdev/incubator-doris/thirdparty/installed/lib64/libbrpc.a(collector.cpp.o): src/service/CMakeFiles/palo_be.dir/doris_main.cpp.o: guard variable for butil::detail::ClassNameHelper::name[abi:cxx11] mold: error: duplicate symbol: /home/bitetheddddt/dbdev/incubator-doris/thirdparty/installed/lib64/libbrpc.a(acceptor.cpp.o): src/exec/libExec.a(data_sink.cpp.o): guard variable for butil::detail::ClassNameHelper::name[abi:cxx11] mold:...

BiteTheDDDDt

protobuf 3.21.2 编译失败

1

**Describe the bug (描述bug)** protobuf 3.21.2 编译失败，该版本的protobuf在Message中加了一个纯虚函数Message* New(Arena* arena) const override = 0; NsheadMessage继承自该类，当前brpc版本为实现该函数 **To Reproduce (复现方法)** **Expected behavior (期望行为)** 编译成功 **Versions (各种版本)** OS: ubuntu 20.04 Compiler: gcc 10 brpc:...

bailongxian

brpc 使用arena分配pb内存编译错误

1

**Describe the bug (描述bug)** incubator-brpc-1.1.0.tar.gz / protobuf-3.19.2.tar.gz / thrift-0.16.0.tar.gz **To Reproduce (复现方法)** 构建brpc /opt/rh/devtoolset-11/root/usr/libexec/gcc/x86_64-redhat-linux/11/ld: ../deps/incubator-brpc/lib/libbrpc.a(list_service.o): in function `google::protobuf::internal::GenericTypeHandler::New(google::protobuf::Arena*)': /usr/local/include/google/protobuf/repeated_ptr_field.h:413: undefined reference to `google::protobuf::ServiceDescriptorProto* google::protobuf::Arena::CreateMaybeMessage(google::protobuf::Arena*)' /opt/rh/devtoolset-11/root/usr/libexec/gcc/x86_64-redhat-linux/11/ld: ../deps/incubator-brpc/lib/libbrpc.a(builtin_service.pb.o): in function `google::protobuf::internal::GenericTypeHandler::New(google::protobuf::Arena*)': /usr/local/include/google/protobuf/repeated_ptr_field.h:413:...

helloqingbing

使用 brpc-java 的 client 访问 bprc-cpp 的server 可行么？

1

如题。 需要一个brpc的java client，但是目前brpc 这个项目没有 java client。 而 brpc-java (https://github.com/baidu/brpc-java) 这个项目有client，所以想问能否使用 bprc-java 的java client 访问 brpc 的cpp server? @jamesge

gtarcoder

自定义内置bvar的名称，如qps、latency

2

当前brpc内置的qps、latency监控名称是由"rpc_server"和service、port拼接起来，看了下代码，应该没有暴露接口给用户自定义该名称，有其他方法修改这些监控项的名称吗？

MonstarCoder

Here is the only usage [example](https://github.com/apache/incubator-brpc/blob/master/build_in_travis_ci.sh#L63). We need to support compilation for the latest Bazel and add a separate doc for that. Ongoing PR: https://github.com/apache/incubator-brpc/pull/1657 Related Issues: https://github.com/apache/incubator-brpc/issues/1689 https://github.com/apache/incubator-brpc/issues/1771 https://github.com/apache/incubator-brpc/issues/1378...

zyearn

Problem: Currently when PR is merged, we can't ensure that it can be built and compiled in MacOS Solution: https://github.com/features/actions has already supported MacOS platform

zyearn

use find_package with SnappyConfig.cmake instead of find_path

3

renzhong

add support for rwlock

3

补充写优先读写锁实现，变量和状态应该算是比较简洁的了，参考了内核写优先设计。 UT里有性能相关测试

hairet