brpc icon indicating copy to clipboard operation
brpc copied to clipboard

修复rpc_channel_connection_count

Open yyweii opened this issue 1 year ago • 0 comments

What problem does this PR solve?

Issue Number:

Problem Summary: 在tcp连接成功,ssl握手失败的情况下,rpc_channel_connection_count会自增。随后fd被close,但是计数却没有减

What is changed and the side effects?

Changed: 只有在Socket::ResetFileDescriptor被成功调用后再自增计数,以使close fd时减计数的逻辑生效 Side effects:

  • Performance effects(性能影响):

  • Breaking backward compatibility(向后兼容性):


Check List:

  • Please make sure your changes are compilable(请确保你的更改可以通过编译).
  • When providing us with a new feature, it is best to add related tests(如果你向我们增加一个新的功能, 请添加相关测试).
  • Please follow Contributor Covenant Code of Conduct.(请遵循贡献者准则).

yyweii avatar Mar 25 '24 14:03 yyweii