brpc icon indicating copy to clipboard operation
brpc copied to clipboard

Support shutdown write and notify for success write

Open chenBright opened this issue 1 year ago • 2 comments

What problem does this PR solve?

Issue Number:

Problem Summary:

What is changed and the side effects?

Changed:

  1. 支持半关闭:无需SetFailed,关闭写入端,但不影响读数据。
  2. 支持在数据写入socket写入成功后调用id_wait回调函数:对于一些请求和响应不是一一对应的场景,例如WebSocket、TCP Stream客户端、Streaming rpc等,只需要关注数据是否写入成功。数据写入socket写入成功后调用id_wait回调函数,可以统计成功率、耗时等。#2545

Side effects:

  • Performance effects(性能影响):

  • Breaking backward compatibility(向后兼容性):


Check List:

  • Please make sure your changes are compilable(请确保你的更改可以通过编译).
  • When providing us with a new feature, it is best to add related tests(如果你向我们增加一个新的功能, 请添加相关测试).
  • Please follow Contributor Covenant Code of Conduct.(请遵循贡献者准则).

chenBright avatar Feb 25 '24 16:02 chenBright

@wwbmmm 有空看看这个PR

chenBright avatar Mar 12 '24 02:03 chenBright

LGTM

wwbmmm avatar Mar 21 '24 05:03 wwbmmm