brpc icon indicating copy to clipboard operation
brpc copied to clipboard

enable aligned new if supported

Open lorinlee opened this issue 2 years ago • 5 comments

What problem does this PR solve?

Issue Number: #2416

Problem Summary:

What is changed and the side effects?

Changed:

Side effects:

  • Performance effects(性能影响):

  • Breaking backward compatibility(向后兼容性):


Check List:

  • Please make sure your changes are compilable(请确保你的更改可以通过编译).
  • When providing us with a new feature, it is best to add related tests(如果你向我们增加一个新的功能, 请添加相关测试).
  • Please follow Contributor Covenant Code of Conduct.(请遵循贡献者准则).

lorinlee avatar Oct 22 '23 14:10 lorinlee

@ehds @wwbmmm @zyearn c++17就先不默认打开了,先默认打开aligned-new吧,辛苦review下看看

lorinlee avatar Oct 22 '23 15:10 lorinlee

The solution is not sophisticated in my opinion. The brpc header file may be included in other translation units, which could be not aligned-new, so the final artifact will be a mixture of aligned-new and non-aligned-new.

uvletter avatar Feb 27 '24 04:02 uvletter