brpc icon indicating copy to clipboard operation
brpc copied to clipboard

[type: new feature] adding integration test workflow

Open loongs-zhang opened this issue 3 years ago • 2 comments

Is your feature request related to a problem? (你需要的功能是否与某个问题有关?) It is inevitable that there are problems in the code of manual review. Adding integration test workflow can effectively solve this problem.

Describe the solution you'd like (描述你期望的解决方法) Adding integration test workflow, it is recommended to reuse the code below https://github.com/apache/incubator-brpc/tree/master/example . At present, I am not familiar with C++ and brpc. I hope that the master can complete it.

Describe alternatives you've considered (描述你想到的折衷方案)

Additional context/screenshots (更多上下文/截图)

loongs-zhang avatar Sep 02 '22 01:09 loongs-zhang

This is a good idea, brpc does not have integration tests yet. However, some existing unit tests are complex enough to cover integration scenarios, such as test/brpc_channel_unittest.cpp. Maybe we can extract these cases separately to make an integration test set.

wwbmmm avatar Sep 06 '22 10:09 wwbmmm

Agree, the main purpose of integration test is to ensure that the new PR will not lead to the failure of important features.

loongs-zhang avatar Sep 06 '22 13:09 loongs-zhang