brpc icon indicating copy to clipboard operation
brpc copied to clipboard

[health check] health_check_path 目前是全局维度的,理想情况下应该是服务维度

Open serverglen opened this issue 3 years ago • 1 comments

Is your feature request related to a problem? (你需要的功能是否与某个问题有关?) health_check_path 目前是全局维度的(gflags方式设置),实际上每个服务的健康检查接口可能都不一样,因此这个应该是服务维度的。

Describe the solution you'd like (描述你期望的解决方法) 在ChannelOptions中增加health_check_path,并且优先级高于全局的health_check_path

Describe alternatives you've considered (描述你想到的折衷方案)

Additional context/screenshots (更多上下文/截图)

serverglen avatar May 13 '22 03:05 serverglen

尝试做了一下,麻烦给看下,新人上路,轻喷。。。https://github.com/apache/incubator-brpc/pull/1806

ZeroLiu2018 avatar Jun 19 '22 06:06 ZeroLiu2018