bookkeeper icon indicating copy to clipboard operation
bookkeeper copied to clipboard

fix replicateRate of batchRead in auto-recover is negative

Open TakaHiR07 opened this issue 5 months ago • 3 comments

Motivation

Currently the replicateRate of batchRead in auto-recover may exceed Integer.MAX_VALUE and then become negative, which would result in batchRead operation stuck.

Changes

deal with the negative situation

TakaHiR07 avatar Jul 10 '25 08:07 TakaHiR07

good jobs, I have a question: should maxBytesToReplicate use long type?

StevenLuMT avatar Jul 12 '25 21:07 StevenLuMT

good jobs, I have a question: should maxBytesToReplicate use long type?

rateLimiter.acquire(int) just support int value. Besides, Integer.max_value means 2GB throughput, it is enough for most situation.

TakaHiR07 avatar Jul 14 '25 02:07 TakaHiR07

good jobs, I have a question: should maxBytesToReplicate use long type?

rateLimiter.acquire(int) just support int value. Besides, Integer.max_value means 2GB throughput, it is enough for most situation because replicate throughput should not be too high.

TakaHiR07 avatar Jul 14 '25 02:07 TakaHiR07