bookkeeper icon indicating copy to clipboard operation
bookkeeper copied to clipboard

Task: upgrade RocksDB

Open dlg99 opened this issue 1 year ago • 4 comments

BK currently uses RocksDB 7.9.2. RocksDB has a bugfix release 7.10.2 (if we decide to to do a minor upgrade for now) and 9.2.1 with variety of performance improvements and features.

We should consider upgrading; I don't know if 9.2.1 would break anything compatibility-wise, 7.10.2 should be safe.

dlg99 avatar May 30 '24 18:05 dlg99

I think we'd better upgrade to 7.10.2 first. Due to 9.2.1 being a major version, we should double-test to see if it breaks the current behaviors.

hangc0276 avatar May 31 '24 00:05 hangc0276

+1 for 7.10.2 first

hezhangjian avatar May 31 '24 00:05 hezhangjian

@dlg99 may I ask the scope of testing to do after the version change in pom file?

bhiwagade-rahul avatar May 31 '24 03:05 bhiwagade-rahul

@bhiwagade-rahul with the minor version upgrade the CI should be good enough; maybe a short perf run. For the major version upgrade we'd want to test with Apache Pulsar, test upgrades, and do more tests under load. Unfortunately perf/load tests are up to contributors as we can't run them on CI.

I don't remember current state of integration tests for upgrade, I vaguely remember that at some point they weren't executed?

dlg99 avatar May 31 '24 16:05 dlg99