bookkeeper icon indicating copy to clipboard operation
bookkeeper copied to clipboard
verified publisher icon apache

test: migrate client module api tests to junit 5

Open sherlock-lin opened this issue 1 year ago • 3 comments

Descriptions of the changes in this PR:

Fix #4322

Main Issue: #4322

sherlock-lin avatar May 21 '24 06:05 sherlock-lin

@shoothzj

sherlock-lin avatar May 21 '24 09:05 sherlock-lin

@lhotari Thanks for you remind, I remember this class too, and it has been used in https://github.com/apache/bookkeeper/blob/5f73147a2803a5147d9d9ba2d28eaa6c79c998a3/bookkeeper-server/src/test/java/org/apache/bookkeeper/test/BookKeeperClusterTestCase.java#L178-L180

hezhangjian avatar May 29 '24 07:05 hezhangjian

minor nits: I think volatile in private volatile String testName; might be useless

done :)

sherlock-lin avatar Jun 06 '24 02:06 sherlock-lin

@lhotari help review，please

sherlock-lin avatar Aug 23 '24 07:08 sherlock-lin

Good work @sherlock-lin

lhotari avatar Aug 23 '24 08:08 lhotari

I'll close and reopen to see if it passes with latest changes in master.

lhotari avatar Aug 23 '24 08:08 lhotari

Thanks for your contribution :)

hezhangjian avatar Aug 26 '24 03:08 hezhangjian