bookkeeper icon indicating copy to clipboard operation
bookkeeper copied to clipboard
verified publisher icon apache

fix: No need to trigger ensembleChangeLoop if all failed bookies are not in current ensemble

Open M1eyu2018 opened this issue 1 year ago • 8 comments

Descriptions of the changes in this PR:

No need to trigger ensembleChangeLoop if all failed bookies are not in current ensemble.

Motivation

Fix the bug issue. https://github.com/apache/bookkeeper/issues/4261

Changes

No need to trigger ensembleChangeLoop if all failed bookies are not in current ensemble.

Master Issue: #

In order to uphold a high standard for quality for code contributions, Apache BookKeeper runs various precommit checks for pull requests. A pull request can only be merged when it passes precommit checks.

Be sure to do all of the following to help us incorporate your contribution quickly and easily:

If this PR is a BookKeeper Proposal (BP):

  • [ ] Make sure the PR title is formatted like: <BP-#>: Description of bookkeeper proposal e.g. BP-1: 64 bits ledger is support
  • [ ] Attach the master issue link in the description of this PR.
  • [ ] Attach the google doc link if the BP is written in Google Doc.

Otherwise:

  • [ ] Make sure the PR title is formatted like: <Issue #>: Description of pull request e.g. Issue 123: Description ...
  • [ ] Make sure tests pass via mvn clean apache-rat:check install spotbugs:check.
  • [ ] Replace <Issue #> in the title with the actual Issue number.

M1eyu2018 avatar Apr 11 '24 03:04 M1eyu2018

#4285 can fix the problem, but this PR is also good for avoiding the unnecessary ensembleChangeLoop. I think this is useful.

horizonzy avatar Apr 11 '24 17:04 horizonzy

@hangc0276 @horizonzy I have added a unit for this PR. PTAL

M1eyu2018 avatar Apr 15 '24 07:04 M1eyu2018

I this related to #4194? /cc @shustsud

lhotari avatar Apr 16 '24 11:04 lhotari

@dlg99 @hangc0276 @eolivelli PTAL, thanks

hezhangjian avatar Jul 08 '24 03:07 hezhangjian

@M1eyu2018 Thanks for your contribution. Would you please help check the failed tests? Thanks.

hangc0276 avatar Jul 08 '24 08:07 hangc0276

Sorry I didn't remember why I close this last week. It maybe a mis-operation. @M1eyu2018 Would you please help check the failed tests? Thanks.

hezhangjian avatar Jul 19 '24 02:07 hezhangjian

Sorry I didn't remember why I close this last week. It maybe a mis-operation. @M1eyu2018 Would you please help check the failed tests? Thanks.

OK, I will check as soon as possible.

M1eyu2018 avatar Jul 19 '24 02:07 M1eyu2018

@hangc0276 @shoothzj I have checked the failed tests.

M1eyu2018 avatar Jul 19 '24 06:07 M1eyu2018