bookkeeper icon indicating copy to clipboard operation
bookkeeper copied to clipboard
verified publisher icon apache

Add tls config to etcd metadata driver

Open alesharik opened this issue 2 years ago • 6 comments

Descriptions of the changes in this PR:

Motivation

Etcd metadata driver should support TLS connections to etcd.

Changes

  • Add metadataServiceConfig config parameter to specify the path for the metadata service configuration file
  • Add EtcdConfig to parse metadata service configuration file and extract TLS config from it
  • Add support to configure TLS connection to EtcdMetadataDriverBase
  • Add smoke test to check if logic above works

alesharik avatar Jun 05 '23 11:06 alesharik

Please fix checkstyle errors to let CI run

dlg99 avatar Jun 10 '23 04:06 dlg99

@dlg99 done, checkstyle errors fixed

alesharik avatar Jun 10 '23 09:06 alesharik

@alesharik Thanks for your contribution. Any updates?

hezhangjian avatar May 03 '24 05:05 hezhangjian

@shoothzj it is ready. CI failed because of other error, and it may be fixed now

alesharik avatar May 03 '24 15:05 alesharik

@alesharik Sorry for my late reply, I recenlty come back to actively work in BookKeeper project. I think we also need documentation about how to config like in #4256 .

Also you need to rebase the code, so we can move forward with this PR.

Thanks for your contribution. cc @dlg99 @eolivelli

hezhangjian avatar May 04 '24 01:05 hezhangjian

@alesharik please add some documentation, rebase, and make sure that the CI passes

dlg99 avatar May 30 '24 19:05 dlg99