bookkeeper icon indicating copy to clipboard operation
bookkeeper copied to clipboard
verified publisher icon apache

Release apache/bookkeeper image with latest GH release for all platforms.

Open tomaszmichalak opened this issue 3 years ago • 4 comments

Motivation

Initial issue link: https://github.com/apache/bookkeeper/issues/3656.

Goal:

  • image build should always point to the latest released version (according to semantic versioning)
  • build image for other platforms (linux/amd64,linux/arm64)

Next steps:

  • perform Docker image release from GH Actions

In order to uphold a high standard for quality for code contributions, Apache BookKeeper runs various precommit checks for pull requests. A pull request can only be merged when it passes precommit checks.

Be sure to do all of the following to help us incorporate your contribution quickly and easily:

If this PR is a BookKeeper Proposal (BP):

  • [ ] Make sure the PR title is formatted like: <BP-#>: Description of bookkeeper proposal e.g. BP-1: 64 bits ledger is support
  • [ ] Attach the master issue link in the description of this PR.
  • [ ] Attach the google doc link if the BP is written in Google Doc.

Otherwise:

  • [ ] Make sure the PR title is formatted like: <Issue #>: Description of pull request e.g. Issue 123: Description ...
  • [ ] Make sure tests pass via mvn clean apache-rat:check install spotbugs:check.
  • [ ] Replace <Issue #> in the title with the actual Issue number.

tomaszmichalak avatar Nov 18 '22 12:11 tomaszmichalak

@eolivelli Can you please comment this PR ?

tomaszmichalak avatar Nov 18 '22 15:11 tomaszmichalak

We use latest only in development locally. All public docker images have a specific tag name. If you plan to push the latest tag to the docker hub, then pointing to the latest released version is a good idea.

  1. Do you use semantic versioning?
  2. Do you release bug fixes to the previous releases (e.g. 4.14.x)?
  3. How do you validate your docker images - when I used Docker Compose from docker, I found it not working with the latest Zookeeper. Maybe you can
  • build a Docker image from Maven using the io.fabric8:docker-maven-plugin plugin
  • execute the end-to-end tests in GH Actions with the specified Zookeeper version for all master branch merges
  • declare the Zookeeper version compatible with Bookkeeper somewhere in the documentation

tomaszmichalak avatar Nov 21 '22 08:11 tomaszmichalak

@zymap I tried to answer all comments.

tomaszmichalak avatar Nov 21 '22 09:11 tomaszmichalak

@tomaszmichalak Thanks for your contribution. Could you please update this PR? Thanks

hezhangjian avatar May 02 '24 20:05 hezhangjian