bookkeeper icon indicating copy to clipboard operation
bookkeeper copied to clipboard

[branch-4.15] Fix the problem that the abnormal file causes the bookie GC fail

Open 1559924775 opened this issue 2 years ago • 3 comments

Descriptions of the changes in this PR:

Motivation When bookie GC encounters an entryLog file with disordered data, a IllegalArgumentException are not caught, resulting in the death of the GC thread and the end of the GC process. This problem is encountered again in the next GC, resulting in the subsequent entrylog being unable to GC. The problem described in this issue(https://github.com/apache/bookkeeper/issues/3604) will cause the entryLog file to be disordered, and will cause the IllegalArgumentException when parsing the entrylog file.

Master Issue: https://github.com/apache/bookkeeper/issues/3607 : Describes the problem to be solved by this pr. https://github.com/apache/bookkeeper/issues/3604 : Describes the phenomenon and causes of disordered entrylog files.

1559924775 avatar Nov 05 '22 15:11 1559924775

@horizonzy Please help take a look at this Pr, thanks a lot.

hangc0276 avatar Jan 11 '23 07:01 hangc0276

LGTM. This problem has already been fixed in the master, but it didn't fix in branch-4.15.

Sorry, it's not the same case. I will test it and reply it again later.

horizonzy avatar Jan 13 '23 05:01 horizonzy

Close this since it is open for a long time without any updates. Feel free to reopen it if you want to continue

zymap avatar Dec 04 '23 03:12 zymap