bookkeeper icon indicating copy to clipboard operation
bookkeeper copied to clipboard

Fix max upper bound for last bucket of timer stats

Open Ghatage opened this issue 2 years ago • 4 comments

Descriptions of the changes in this PR:

Motivation

Codahale metrics are used for dashboarding with Grafana and we must rely on these values to be accurate in order to measure the stability and performance of the service. For Codahale's fast timer, when a value falls in the last bucket, the max is reported as the upper bound of the last bucket (Long.MAX_VALUE) which can lead to erroneous 99 percentile values.

Changes

We change the way we get the max value recorded if the bucket we're dealing with is the last bucket (for 99th percentile). If we are in the last bucket, we return the actual max, otherwise we can return getBucketBound() which should return the accurate calculated value. Also added a test.

Ghatage avatar Oct 17 '22 14:10 Ghatage