bookkeeper icon indicating copy to clipboard operation
bookkeeper copied to clipboard
verified publisher icon apache

Documentation for readReorderThresholdPendingRequests is missing

Open lhotari opened this issue 3 years ago • 1 comments

BUG REPORT

Describe the bug

Documentation for readReorderThresholdPendingRequests is missing from https://bookkeeper.apache.org/docs/reference/config/

To Reproduce

Steps to reproduce the behavior:

  1. Go to https://bookkeeper.apache.org/docs/reference/config/
  2. Search for "readReorderThresholdPendingRequests"
  3. No results.

Expected behavior

readReorderThresholdPendingRequests should be documented

Additional context

readReorderThresholdPendingRequests was provided by #1504 to resolve issue #1489 . The issue is about the ensemblePlacementPolicyOrderSlowBookies solution which was added by #883 (commit cc84042a4d) to address #709 .

lhotari avatar Sep 30 '22 22:09 lhotari

What I'm wondering about ensemblePlacementPolicyOrderSlowBookies is that I don't see getEnsemblePlacementPolicySlowBookies() method being called in the code base at all. Is it a dead option? Am I missing some magical way how the configuration gets used in Bookkeeper code base? Could someone check?

lhotari avatar Sep 30 '22 22:09 lhotari