bookkeeper icon indicating copy to clipboard operation
bookkeeper copied to clipboard

Fix race condition.

Open horizonzy opened this issue 2 years ago • 4 comments

Motivation

fixes-#3362

horizonzy avatar Jun 26 '22 02:06 horizonzy

Nice catch!

Please add more details about how the race condition happened.

see #3362, update the detail info

horizonzy avatar Jun 26 '22 09:06 horizonzy

Overall look good to me. Could you please add a unit test to cover this?

fine.

horizonzy avatar Jun 27 '22 06:06 horizonzy

I left couple of comments to address.

As for the original issue, is this a theoretical find or from a production case? Most of the ledger-specific mutations in BK happen in the ordered executor where the ledgerid is used as a key, so the mutations should happen on the same thread sequentially.

This is not real case, just for analyze. We can't ensure the user open ledger and close ledger in same thread, so if you want to process register and unregister serially, should handle it in AbstractZkLedgerManageer, not outside by invoke user.

horizonzy avatar Jun 29 '22 02:06 horizonzy

fix old workflow,please see #3455 for detail

StevenLuMT avatar Aug 24 '22 08:08 StevenLuMT

rerun failure checks

horizonzy avatar Feb 17 '23 02:02 horizonzy

Close this since it is open for a long time without any updates. Feel free to reopen it if you want to continue

zymap avatar Dec 04 '23 03:12 zymap