bookkeeper icon indicating copy to clipboard operation
bookkeeper copied to clipboard

DEBUG log level by default in Bookkeeper 4.15.0 release

Open OlegKashtanov opened this issue 3 years ago • 3 comments

BUG REPORT

Describe the bug

In official image apache/bookkeeper:4.15.0 there is a DEBUG log level by default when you start the container even the logging is configured for using INFO level. BK java system properties:

-Dlog4j.configurationFile=log4j2.xml -Dbookkeeper.log.root.level=INFO -Dbookkeeper.log.root.appender=CONSOLE

log4j2.xml:

<Configuration status="warn" monitorInterval="10">
    <Properties>
        <Property name="bookkeeper.log.dir">.</Property>
        <Property name="bookkeeper.log.file">bookkeeper-server.log</Property>
        <Property name="bookkeeper.log.root.level">INFO</Property>
        <Property name="bookkeeper.log.root.appender">CONSOLE</Property>
    </Properties>
    <Appenders>
        <Console name="CONSOLE" target="SYSTEM_OUT">
            <PatternLayout pattern="%d{ISO8601} - %-5p - [%t:%C{1}@%L] - %m%n"/>
        </Console>
        <File name="TRACEFILE" fileName="${sys:bookkeeper.log.dir}/bookkeeper-trace.log">
            <PatternLayout pattern="%d{ISO8601} - %-5p [%t:%C{1}@%L][%ndc] - %m%n"/>
        </File>
        <RollingFile name="ROLLINGFILE" fileName="${sys:bookkeeper.log.dir}/${sys:bookkeeper.log.file}" filePattern="${sys:bookkeeper.log.dir}/${sys:bookkeeper.log.file}%d{.yyyy-MM-dd}">
            <PatternLayout pattern="%d{ISO8601} - %-5p [%t:%C{1}@%L] - %m%n"/>
            <Policies>
                <TimeBasedTriggeringPolicy modulate="true"/>
            </Policies>
            <DefaultRolloverStrategy max="100"/>
        </RollingFile>
    </Appenders>
    <Loggers>
        <Root level="${sys:bookkeeper.log.root.level}">
            <AppenderRef ref="${sys:bookkeeper.log.root.appender}"/>
        </Root>
    </Loggers>
</Configuration>

There is no issue with apache/bookkeeper:4.14.5, apache/bookkeeper:4.14.4, apache/bookkeeper:4.14.3 and the latest images.

So, there is issue only in branch-4.15. Comparing master and branch-4.15, I observed the changes which are related to the logging in bk_test_bin_common.sh script.

To Reproduce

Steps to reproduce the behavior:

  1. Start the container with bookkeeper:4.15.0 image
docker run -it \
     --env JAVA_HOME=/usr/lib/jvm/java-11 \
     --entrypoint "/bin/bash" \
     apache/bookkeeper:4.15.0 \
     -c "/opt/bookkeeper/bin/bookkeeper localbookie 3"
  1. Look at the log level.

Expected behavior The INFO log level is expected.

OlegKashtanov avatar May 24 '22 15:05 OlegKashtanov

@Shoothzj can you look into that ?

nicoloboschi avatar May 24 '22 16:05 nicoloboschi

@nicoloboschi if you and @OlegKashtanov are not againts my help, i would like to help)

sudoHackIn avatar May 29 '22 18:05 sudoHackIn

Sorry for my late reply. I must missed messages. @sudoHackIn Thanks for your help, I can assign this issue to you.

hezhangjian avatar May 30 '22 00:05 hezhangjian

Hello,

Is there any fix on this ? We're running bookkeeper-4.15.2 and zookeeper-3.8.0 and both have the same issue. We cannot run the log level in any other way lower than DEBUG, it also cannot write in a file, only via journalctl. Is it a bug with this version ?

Thank you

<Configuration status="warn" monitorInterval="10">
    <Properties>
        <Property name="bookkeeper.log.dir">/var/log/bookkeeper</Property>
        <Property name="bookkeeper.log.file">bookkeeper-server.log</Property>
        <Property name="bookkeeper.log.root.level">INFO</Property>
        <Property name="bookkeeper.log.root.appender">CONSOLE,ROLLINGFILE</Property>
    </Properties>
    <Appenders>
        <Console name="CONSOLE" target="SYSTEM_OUT">
            <PatternLayout pattern="%d{ISO8601} - %-5p - [%t:%C{1}@%L] - %m%n"/>
        </Console>
        <File name="TRACEFILE" fileName="${sys:bookkeeper.log.dir}/bookkeeper-trace.log">
            <PatternLayout pattern="%d{ISO8601} - %-5p [%t:%C{1}@%L][%ndc] - %m%n"/>
        </File>
        <RollingFile name="ROLLINGFILE" fileName="${sys:bookkeeper.log.dir}/${sys:bookkeeper.log.file}" filePattern="${sys:bookkeeper.log.dir}/${sys:bookkeeper.log.file}%d{.yyyy-MM-dd}">
            <PatternLayout pattern="%d{ISO8601} - %-5p [%t:%C{1}@%L] - %m%n"/>
            <Policies>
                <TimeBasedTriggeringPolicy modulate="true"/>
            </Policies>
            <DefaultRolloverStrategy max="100"/>
        </RollingFile>
    </Appenders>
    <Loggers>
        <Root level="${sys:bookkeeper.log.root.level}">
            <AppenderRef ref="${sys:bookkeeper.log.root.appender}"/>
        </Root>
    </Loggers>
</Configuration>

stanbog avatar Nov 08 '22 06:11 stanbog

Tested ok with version `4.16.3、4.15.3``. I think we can close this issue now.

hezhangjian avatar Apr 11 '24 03:04 hezhangjian