bookkeeper icon indicating copy to clipboard operation
bookkeeper copied to clipboard

Published 20 hours ago • verified publisher icon apache

support ipv6 address validation

Open wangjialing218 opened this issue 2 years ago • 1 comments

Motivation

current bookkeeper URI does not support ipv6 address validate.

Changes

Support ipv6 address validate. mainly copy codes from https://github.com/apache/pulsar/pull/8120#issue-707796479

wangjialing218 avatar Mar 30 '22 09:03 wangjialing218

fix old workflow,please see #3455 for detail

StevenLuMT avatar Aug 24 '22 08:08 StevenLuMT

@horizonzy @zymap Please help take a look, thanks.

hangc0276 avatar Mar 20 '23 03:03 hangc0276

@wangjialing218 Would you please help rebase the master? thanks.

hangc0276 avatar Mar 20 '23 03:03 hangc0276

Thanks for the help. Do we need some documents for this?

jiazhai avatar Mar 20 '23 03:03 jiazhai

In org.apache.bookkeeper.net.DNS#reverseDns, it can't handle ipv6, also need to fix it.

@horizonzy reverseDns only execute when advertisedAddress is not set. In this case, the ipv6 address of the host will be ignored. Let's keep this behave unchanged, bookie server will advertise ipv4 address when advertisedAddress is not set.

To enable advertise ipv6 address for bookie server, we should set advertisedAddress with ipv6 address of the host.

wangjialing218 avatar Apr 10 '23 08:04 wangjialing218

Sorry for not getting back to you sooner. I'm reviewing it now.

horizonzy avatar Apr 13 '23 08:04 horizonzy

Close this since it is open for a long time without any updates. Feel free to reopen it if you want to continue

zymap avatar Dec 04 '23 03:12 zymap