bookkeeper icon indicating copy to clipboard operation
bookkeeper copied to clipboard

fix 2655 bookie will be down (out of memory), when there are a lots of ledgers under /ledgers/underreplication/ledgers to replication

Open baomingyu opened this issue 3 years ago • 3 comments

Descriptions of the changes in this PR:

Motivation

In some exception branch, lh is not be unregister from listener, so I make this change.

Changes

if (rc != BKException.Code.OK) { if (lh != null && !doRecovery) { bk.getClientCtx().getLedgerManager() .unregisterLedgerMetadataListener(ledgerId, lh); } openComplete(bk.getReturnRc(BKException.Code.ReadException), null); }

baomingyu avatar Mar 31 '21 08:03 baomingyu

thanks for providing your fix. The fix makes sense to me.

From my point of view it is hard to see how this fix is related to the original problem. do you have any log, memory dump... or any other hint that points into this direction ?

This scene is realy hard to see, In my scene , I change 3 3 2 to 2 2 2 , and replicaiton will mark this scene .

my dump file in mat image

baomingyu avatar Apr 21 '21 12:04 baomingyu

fix old workflow,please see #3455 for detail

StevenLuMT avatar Aug 24 '22 08:08 StevenLuMT

@baomingyu Thanks for your contribution, could you please update this PR?

shoothzj avatar May 02 '24 20:05 shoothzj