bookkeeper icon indicating copy to clipboard operation
bookkeeper copied to clipboard

[MINOR] Code refactor Bookie env check during start.

Open lifepuzzlefun opened this issue 4 years ago • 6 comments

[MINOR] code refactor Bookie env check during start.

move bookie environment check logic code to BookieEnvirnmentChecker this may makes code much clearer.

no logic change or method delete.

lifepuzzlefun avatar Jan 30 '21 10:01 lifepuzzlefun

@WJL3333 thanks for your patch.

is this a preparatory patch for some other contribution or is it a code cleanup without any other follow up work ?

eolivelli avatar Feb 01 '21 09:02 eolivelli

@eolivelli thanks for reply. this patch is just code cleanup refactor, no more follow up work.

lifepuzzlefun avatar Feb 01 '21 10:02 lifepuzzlefun

@fpj yes, this is just for organize propose~

lifepuzzlefun avatar Feb 03 '21 08:02 lifepuzzlefun

@fpj do you think we can go ahead an merge this patch ?

eolivelli avatar Feb 17 '21 15:02 eolivelli

@reddycharan can you PTAL?

Ghatage avatar Apr 10 '21 14:04 Ghatage

fix old workflow,please see #3455 for detail

StevenLuMT avatar Aug 24 '22 08:08 StevenLuMT