bookkeeper icon indicating copy to clipboard operation
bookkeeper copied to clipboard

Update ServerConfiguration to use ConfigKey and ConfigKeyGroup

Open sijie opened this issue 6 years ago • 6 comments

Descriptions of the changes in this PR:

Motivation

This PR is part of BP-37 - using the new configuration framework to re-organize server configuration

Changes

Update server configuration to use ConfigKey and ConfigKeyGroup

Master Issue: #1867


In order to uphold a high standard for quality for code contributions, Apache BookKeeper runs various precommit checks for pull requests. A pull request can only be merged when it passes precommit checks. However running all the precommit checks can take a long time, some trivial changes don't need to run all the precommit checks. You can check following list to skip the tests that don't need to run for your pull request. Leave them unchecked if you are not sure, committers will help you:

  • [ ] [skip bookkeeper-server bookie tests]: skip testing org.apache.bookkeeper.bookie in bookkeeper-server module.
  • [ ] [skip bookkeeper-server client tests]: skip testing org.apache.bookkeeper.client in bookkeeper-server module.
  • [ ] [skip bookkeeper-server replication tests]: skip testing org.apache.bookkeeper.replication in bookkeeper-server module.
  • [ ] [skip bookkeeper-server tls tests]: skip testing org.apache.bookkeeper.tls in bookkeeper-server module.
  • [ ] [skip bookkeeper-server remaining tests]: skip testing all other tests in bookkeeper-server module.
  • [ ] [skip integration tests]: skip docker based integration tests. if you make java code changes, you shouldn't skip integration tests.
  • [ ] [skip build java8]: skip build on java8. ONLY skip this when ONLY changing files under documentation under site.
  • [ ] [skip build java9]: skip build on java9. ONLY skip this when ONLY changing files under documentation under site.


Be sure to do all of the following to help us incorporate your contribution quickly and easily:

If this PR is a BookKeeper Proposal (BP):

  • [ ] Make sure the PR title is formatted like: <BP-#>: Description of bookkeeper proposal e.g. BP-1: 64 bits ledger is support
  • [ ] Attach the master issue link in the description of this PR.
  • [ ] Attach the google doc link if the BP is written in Google Doc.

Otherwise:

  • [ ] Make sure the PR title is formatted like: <Issue #>: Description of pull request e.g. Issue 123: Description ...
  • [ ] Make sure tests pass via mvn clean apache-rat:check install spotbugs:check.
  • [ ] Replace <Issue #> in the title with the actual Issue number.

sijie avatar Dec 29 '18 05:12 sijie

run integration tests

sijie avatar Jan 14 '19 22:01 sijie

retest this please

eolivelli avatar Jan 17 '19 12:01 eolivelli

@sijie it is worth to rebase this patch and ship it for 4.10, do you have cycles ?

eolivelli avatar Jul 27 '19 12:07 eolivelli

would like to put it into 4.11

jiazhai avatar Oct 29 '19 13:10 jiazhai

run integration tests

Ghatage avatar Jun 10 '20 22:06 Ghatage

@sijie can you please rebase ? if you want this to be part of 4.11 release

eolivelli avatar Jun 11 '20 08:06 eolivelli