bigtop icon indicating copy to clipboard operation
bigtop copied to clipboard

BIGTOP-3250: Upgrade Presto docker image

Open youngwookim opened this issue 5 years ago • 9 comments

youngwookim avatar Oct 16 '19 08:10 youngwookim

Looks good +1

evans-ye avatar Oct 18 '19 18:10 evans-ye

@evans-ye Thanks for the review. BTW, Would you mind helping me to push new images to DockerHub/bigtop?

youngwookim avatar Oct 21 '19 03:10 youngwookim

Yes. Let me try it. However, what's your purpose? An image for test&dev?

evans-ye avatar Oct 23 '19 09:10 evans-ye

@evans-ye The docker image is not only for testing, but we need to serve a customized docker image for users to create k8s object. Our docker images would be customized and configured based on original images. so I think we need our own repo for the images.

youngwookim avatar Oct 24 '19 03:10 youngwookim

--squash is an experimental feature. Need to add --experimental option when starting up docker daemon. I've added this on our build server slave06:

cat /etc/sysconfig/docker
# The max number of open files for the daemon itself, and all
# running containers.  The default value of 1048576 mirrors the value
# used by the systemd service unit.
DAEMON_MAXFILES=1048576

# Additional startup options for the Docker daemon, for example:
# OPTIONS="--ip-forward=true --iptables=true"
# By default we limit the number of open files per container
OPTIONS="--default-ulimit nofile=1024:4096 --experimental"

# How many seconds the sysvinit script waits for the pidfile to appear
# when starting the daemon.
DAEMON_PIDFILE_TIMEOUT=10

The built image: https://hub.docker.com/r/bigtop/prestosql-worker

evans-ye avatar Oct 26 '19 17:10 evans-ye

Thanks @evans-ye I'll merge this patch to cnb branch.

youngwookim avatar Oct 29 '19 05:10 youngwookim

NP. If you need my help on other task. Ping me heavily. I might miss reading the message.

evans-ye avatar Oct 29 '19 17:10 evans-ye

@evans-ye, I found the 'worker' image https://hub.docker.com/r/bigtop/prestosql-worker But 'coordinator' does not exist yet. Please build the 'coordinator' image too https://github.com/apache/bigtop/tree/cnb/prestosql/docker/coordinator

youngwookim avatar Oct 30 '19 08:10 youngwookim

Wanted to understand this Image creation, Any Documents or screenshots kindly share.

Akanksha-kedia avatar Jul 18 '23 06:07 Akanksha-kedia