bigtop
bigtop copied to clipboard
apache
Expanded Hive Testing
These tests validate the Hive JDBC driver and have fleshed out usage to include complex, generated SQL and meta-data testing.
Hi @bharatm363 can you create a JIRA on BIGTOP and describe what feature you'd like to add?
@evans-ye I have created an issue on JIRA for this testing, https://issues.apache.org/jira/browse/BIGTOP-3049, please let me know if that is correct.
Thanks for the comments, I'll look into these, I'm going to refactor it some to make everything more readable and address some of the points you raised above. @evans-ye
Sure. Just want to let you know that it doesn't mean that everything I comment need to be addressed. If you think I'm wrong, reply with your thought.
@evans-ye Uploading some changes now, the main thing that I didn't directly address were the sql calls which are still performed in a large group. I thought that would be better as they all test the same kind of behavior without major differences between each one.
Aside the code, another thing we need to do is to squash all the commits into one commit.
See here: https://cwiki.apache.org/confluence/display/BIGTOP/How+to+Contribute#HowtoContribute-Howtogeneratepatchesbycreatingpullrequests.
@evans-ye In terms of squashing I'm not sure I have the access to do so since the pull request is in the apache repo. Would you be able to squash the commits in this pull request?
@bharatm363 sorry to answer back late. I was on a week long vacation ;) I know there's a squash button in Github, however since github is just only a mirror of Bigtop codebase, we don't use it more than reviewing the code.
Usually I'll just rebase my folked branch which creates the PR. Afterwards the changes shall be reflected.