BIGTOP-2766. [Puppet] Spark worker startup failed due to default master_url is yarn

Open evans-ye opened this issue 8 years ago • 3 comments

May 10 '17 19:05 evans-ye

@evans-ye while you're updating spark's init.pp, would you consider replacing the spark-datanucleus package definition with an include spark::datanucleus?

https://github.com/evans-ye/bigtop/blob/aeb72aa14ecc3363723dce542f631aea2faaba41/bigtop-deploy/puppet/modules/spark/manifests/init.pp#L158

As you noted in BIGTOP-2764, including the class seems better than redefining the package.

May 11 '17 15:05 kwmonroe

Thanks for mentioning here. I intentionally left the include part out of this PR to avoid dup work in BIGTOP-2764. Since I'll rebase anyway, I suggest you to submit a patch for BIGTOP-2764, and I'll rebase on it.

May 11 '17 16:05 evans-ye

Seems no objection for two days. I need to get thing rolling to fix spark deployment in provisioner. So I'll commit now. Thanks for your high quality review @kwmonroe.

May 15 '17 12:05 evans-ye