bigtop icon indicating copy to clipboard operation
bigtop copied to clipboard

BIGTOP-4034: Add python3 support in bigtop-select

Open arshadmohammad opened this issue 2 years ago • 3 comments

Description of PR

Added python3 support in bigtop-select

How was this patch tested?

Applied changes on already installed ambari hadoop cluster executed below commands, all got executed successfully

ambari-python-wrap /usr/lib/bigtop-select/distro-select versions
ambari-python-wrap /usr/lib/bigtop-select/distro-select packages
ambari-python-wrap /usr/lib/bigtop-select/distro-select status

For code changes:

  • [ ] Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'BIGTOP-3638. Your PR title ...')?
  • [ ] Make sure that newly added files do not have any licensing issues. When in doubt refer to https://www.apache.org/licenses/

arshadmohammad avatar Oct 27 '23 18:10 arshadmohammad

Thank you for your contribution, @arshadmohammad. Building RPM succeeded with your PR.

$ curl -sL https://github.com/apache/bigtop/pull/1203.diff | git apply
$ ./gradlew bigtop-select-clean bigtop-select-pkg repo

...
BUILD SUCCESSFUL in 9s

But after that, running *-select failed due to the lack of python3.

$ ./docker-hadoop.sh -d -dcp -C config_centos-7.yaml -G -L -k bigtop-utils -c 1
$ ./docker-hadoop.sh -dcp -e 1 bash
# yum install -y bigtop-select

...

Complete!
# /usr/lib/bigtop-select/conf-select 
/usr/bin/env: python3: No such file or directory
# /usr/lib/bigtop-select/distro-select 
/usr/bin/env: python3: No such file or directory

We should add a dependency on python3 to bigtop-select's spec file. Would you do that referring to other spec files such as Phoenix?

sekikn avatar Oct 30 '23 04:10 sekikn

@arshadmohammad It seems you haven't taken action on the review for several months. Do you still want to continue with this PR? If you don't have time to continue maintaining it, you can close it for now, to ensure that this matter can continue to move forward.

JiaLiangC avatar Apr 22 '24 03:04 JiaLiangC

@arshadmohammad Hello, if you really don't have time, I can accept this PR in a week.

timyuer avatar Apr 24 '24 02:04 timyuer