beam icon indicating copy to clipboard operation
beam copied to clipboard

[DO NOT MERGE] Run all PostCommit and PreCommit Tests against Release Branch

Open Amar3tto opened this issue 3 weeks ago • 10 comments

Tests run on GHA should be queued shortly.

Amar3tto avatar Dec 08 '25 19:12 Amar3tto

Summary of Changes

Hello @Amar3tto, I'm Gemini Code Assist[^1]! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a temporary, non-mergeable change to facilitate the testing of PostCommit and PreCommit test suites against a release branch. It adds an empty JSON file, release/trigger_all_tests.json, which is expected to act as a trigger for GitHub Actions (GHA) to queue and execute these tests.

Highlights

  • New Configuration File: Introduced release/trigger_all_tests.json, an empty JSON file, likely intended as a trigger or placeholder for CI/CD test configurations.
  • Test Execution Strategy: This pull request is a "DO NOT MERGE" placeholder, designed to experiment with running all PostCommit and PreCommit tests specifically against a release branch.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with :thumbsup: and :thumbsdown: on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

[^1]: Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

gemini-code-assist[bot] avatar Dec 08 '25 19:12 gemini-code-assist[bot]

Test Results

12 files  +    8  12 suites  +8   1h 45m 33s ⏱️ + 1h 25m 10s 15 tests  - 2 265  15 ✅  - 1 563  0 💤  -   702  0 ❌ ±0  15 runs   - 4 547  15 ✅  - 2 847  0 💤  - 1 700  0 ❌ ±0 

Results for commit 31283f67. ± Comparison against base commit 2efedfd4.

github-actions[bot] avatar Dec 08 '25 20:12 github-actions[bot]

Assigning reviewers:

R: @liferoad for label build.

Note: If you would like to opt out of this review, comment assign to next reviewer.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

github-actions[bot] avatar Dec 08 '25 22:12 github-actions[bot]

The "too-many-pings" issue is another grpc issue that causes flaky tests (e.g. in workflow https://github.com/apache/beam/blob/31283f67d5bb9ea033782775dfcebccb18ef3bae/.github/workflows/beam_PreCommit_Python.yml). We may have to cherry pick #37013 and #37021.

shunping avatar Dec 09 '25 01:12 shunping

The workflow https://github.com/apache/beam/blob/31283f67d5bb9ea033782775dfcebccb18ef3bae/.github/workflows/beam_PostCommit_Python_ValidatesContainer_Dataflow.yml failed due to the old github runner version is in use (2.318.0)

shunping avatar Dec 09 '25 01:12 shunping

Looking at failures:

  • PreCommit Java ElasticSearch IO Direct - failing because of https://github.com/apache/beam/pull/36670 which changed the workflow, but didn't make it onto the release branch. This should be harmless to ignore.
  • PreCommit Java GCP IO Direct - not sure why this is failing and this requires further investigation. It looks like it was resolved on the master branch on Dec 1: https://github.com/apache/beam/actions/workflows/beam_PreCommit_Java_GCP_IO_Direct.yml?page=2&query=branch%3Amaster+event%3Aschedule
  • The rest all are Dataflow issues, likely caused by the Dataflow containers not being published.

AIs:

  • [ ] @shunping please follow go/beam-release#during-release to publish Dataflow containers
  • [ ] @Amar3tto and @shunping please follow up and investigate why PreCommit Java GCP IO Direct is failing

damccorm avatar Dec 09 '25 15:12 damccorm

Looking at failures:

  • PreCommit Java ElasticSearch IO Direct - failing because of [Elasticsearch] Add support for v9.x #36670 which changed the workflow, but didn't make it onto the release branch. This should be harmless to ignore.
  • PreCommit Java GCP IO Direct - not sure why this is failing and this requires further investigation. It looks like it was resolved on the master branch on Dec 1: https://github.com/apache/beam/actions/workflows/beam_PreCommit_Java_GCP_IO_Direct.yml?page=2&query=branch%3Amaster+event%3Aschedule
  • The rest all are Dataflow issues, likely caused by the Dataflow containers not being published.

AIs:

  • [ ] @shunping please follow go/beam-release#during-release to publish Dataflow containers
  • [ ] @Amar3tto and @shunping please follow up and investigate why PreCommit Java GCP IO Direct is failing

I think this is expected, because it was fixed as part of BOM upgrade. Please check my comment: https://github.com/apache/beam/pull/36919#issuecomment-3600240300

Amar3tto avatar Dec 09 '25 15:12 Amar3tto

@shunping please follow go/beam-release#during-release to publish Dataflow containers

ACK. Working on this right now.

shunping avatar Dec 09 '25 16:12 shunping

Looking at failures:

  • PreCommit Java ElasticSearch IO Direct - failing because of [Elasticsearch] Add support for v9.x #36670 which changed the workflow, but didn't make it onto the release branch. This should be harmless to ignore.
  • PreCommit Java GCP IO Direct - not sure why this is failing and this requires further investigation. It looks like it was resolved on the master branch on Dec 1: https://github.com/apache/beam/actions/workflows/beam_PreCommit_Java_GCP_IO_Direct.yml?page=2&query=branch%3Amaster+event%3Aschedule
  • The rest all are Dataflow issues, likely caused by the Dataflow containers not being published.

AIs:

  • [ ] @shunping please follow go/beam-release#during-release to publish Dataflow containers
  • [ ] @Amar3tto and @shunping please follow up and investigate why PreCommit Java GCP IO Direct is failing

I think this is expected, because it was fixed as part of BOM upgrade. Please check my comment: #36919 (comment)

I see - specifically the changes to FakeDatasetService.java are what fixed this. I think it is fine then, and we should be unblocked once Dataflow containers are published

damccorm avatar Dec 09 '25 18:12 damccorm

@shunping please follow go/beam-release#during-release to publish Dataflow containers

ACK. Working on this right now.

The dataflow containers for rc2 should be all in place now. Please let me know if you see any problems. @damccorm @Amar3tto

shunping avatar Dec 09 '25 22:12 shunping

@shunping please follow go/beam-release#during-release to publish Dataflow containers

ACK. Working on this right now.

The dataflow containers for rc2 should be all in place now. Please let me know if you see any problems. @damccorm @Amar3tto

Thanks, All passed

Amar3tto avatar Dec 10 '25 18:12 Amar3tto