beam icon indicating copy to clipboard operation
beam copied to clipboard

Use Topological ordering during ProcessBundle in SDKHarness

Open Suvrat1629 opened this issue 3 weeks ago • 5 comments

Please add a meaningful description for your change here


Fixes: #19062 Compute transforms in topological order with QueryablePipeline and use a LoadingCache keyed by descriptor id to avoid recomputing. Detect cycles by validating the topo list covers all transforms; the loader throws IllegalStateException on incomplete ordering. On loader failure (e.g., cycle), fall back to the prior descriptor-order path so ProcessBundle still succeeds. Add tests covering cache population/identity and cycle -> fallback behavior: testTopologicalCacheProducesAndCachesOrder testTopologicalCacheThrowsOnCycleAndProcessBundleFallsBackToDescriptorOrder Include transforms in the Components passed to QueryablePipeline in the cache loader so ordering can be computed correctly.

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • [x] Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • [ ] Update CHANGES.md with noteworthy changes.
  • [ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels Python tests Java tests Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

Suvrat1629 avatar Dec 06 '25 12:12 Suvrat1629

Summary of Changes

Hello @Suvrat1629, I'm Gemini Code Assist[^1]! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly refines how pipeline transforms are processed within the SDKHarness by implementing topological sorting. This change ensures that operations are executed in their correct dependency order, which is crucial for data processing pipelines. To optimize performance, a caching layer has been added for the computed topological orders. Furthermore, the system is made more resilient by including robust cycle detection and a fallback mechanism that reverts to the prior processing method if any issues arise during topological sorting, ensuring continuous operation.

Highlights

  • Topological Ordering: Transforms within ProcessBundle in the SDKHarness are now processed using topological ordering, ensuring correct dependency execution.
  • Caching Mechanism: A LoadingCache is introduced to store the computed topological order, keyed by descriptor ID, preventing redundant computations.
  • Cycle Detection and Fallback: The system detects cycles in the pipeline definition during topological sorting. If a cycle is found or the loader fails, it gracefully falls back to the previous descriptor-order processing to maintain stability.
  • Enhanced QueryablePipeline: The QueryablePipeline now includes all relevant Components (coders, pcollections, transforms, windowing strategies) when computing the topological order, ensuring accuracy.
  • New Tests: New unit tests (testTopologicalOrderRespectsDependency, testProcessBundleCreatesRunnersForAllTransformsUsingTopologicalCache) have been added to validate the topological ordering, caching, and fallback behavior.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with :thumbsup: and :thumbsdown: on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

[^1]: Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

gemini-code-assist[bot] avatar Dec 06 '25 12:12 gemini-code-assist[bot]

/gemini review

Suvrat1629 avatar Dec 06 '25 12:12 Suvrat1629

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

github-actions[bot] avatar Dec 06 '25 12:12 github-actions[bot]

Assigning reviewers:

R: @Abacn for label java.

Note: If you would like to opt out of this review, comment assign to next reviewer.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

github-actions[bot] avatar Dec 07 '25 14:12 github-actions[bot]

/gemini review

Suvrat1629 avatar Dec 07 '25 17:12 Suvrat1629

Reminder, please take a look at this pr: @Abacn

github-actions[bot] avatar Dec 15 '25 12:12 github-actions[bot]

Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment assign to next reviewer:

R: @chamikaramj for label java.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

github-actions[bot] avatar Dec 18 '25 12:12 github-actions[bot]