beam icon indicating copy to clipboard operation
beam copied to clipboard

Replace VarInt.getLength with Protobuf's branchless implementation

Open sjvanrossum opened this issue 4 weeks ago • 3 comments

See https://github.com/protocolbuffers/protobuf/blob/0a2f7757e38b07c2e40c5c885a7100e8c16eb40f/java/core/src/main/java/com/google/protobuf/CodedOutputStream.java#L700 for details. This change copies Protobuf's branchless implementation for varint length calculation.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • [ ] Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • [ ] Update CHANGES.md with noteworthy changes.
  • [ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels Python tests Java tests Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

sjvanrossum avatar Dec 02 '25 11:12 sjvanrossum

Summary of Changes

Hello @sjvanrossum, I'm Gemini Code Assist[^1]! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on optimizing the calculation of variable-length integer (VarInt) encoding lengths within the VarInt utility class. By integrating a branchless algorithm derived from Protocol Buffers, the change aims to enhance performance by eliminating conditional jumps and utilizing efficient bitwise operations, resulting in a faster and more streamlined length determination process.

Highlights

  • Performance Optimization: Replaced the iterative VarInt.getLength calculation with a branchless, bit-manipulation-based implementation inspired by Google's Protobuf library for both int and long values.
  • Code Modernization: Adopted a more efficient and modern approach for varint length calculation, leveraging Integer.numberOfLeadingZeros and Long.numberOfLeadingZeros for improved performance.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with :thumbsup: and :thumbsdown: on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

[^1]: Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

gemini-code-assist[bot] avatar Dec 02 '25 11:12 gemini-code-assist[bot]

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

github-actions[bot] avatar Dec 02 '25 14:12 github-actions[bot]

Need to fix spotless also

scwhittle avatar Dec 03 '25 09:12 scwhittle