beam icon indicating copy to clipboard operation
beam copied to clipboard

Fix triggering frequency documentation validation

Open Arunodoy18 opened this issue 1 month ago • 7 comments

Please add a meaningful description for your change here


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • [ ] Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • [ ] Update CHANGES.md with noteworthy changes.
  • [ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels Python tests Java tests Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

Arunodoy18 avatar Nov 22 '25 21:11 Arunodoy18

Summary of Changes

Hello @Arunodoy18, I'm Gemini Code Assist[^1]! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the Apache Beam BigQueryIO connector by extending triggering frequency validation and documentation to include the STORAGE_API_AT_LEAST_ONCE write method. It also introduces general-purpose utility functions for escaping and unescaping glob wildcard characters in file paths within the FileSystems class, improving robustness when dealing with dynamic file specifications. Additionally, it includes a test to ensure compatibility with Change Data Capture (CDC) using the Storage Write API.

Highlights

  • BigQueryIO Triggering Frequency Validation: The BigQueryIO connector now correctly validates and documents the triggeringFrequency option for the STORAGE_API_AT_LEAST_ONCE write method when writing unbounded PCollections. This includes updating documentation, validation logic, and removing an outdated warning.
  • Glob Wildcard Escaping Utilities: New utility methods, escapeGlobWildcards and unescapeGlobWildcards, have been added to FileSystems to allow for proper handling of glob wildcard characters (*, ?, {, }) in file paths by escaping or unescaping them.
  • Change Data Capture (CDC) Support: A minor adjustment in StorageApiWriteUnshardedRecords and a new test case confirm that Change Data Capture (CDC) functionality is supported and does not cause IllegalStateException when using the STORAGE_WRITE_API method.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with :thumbsup: and :thumbsdown: on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

[^1]: Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

gemini-code-assist[bot] avatar Nov 22 '25 21:11 gemini-code-assist[bot]

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

github-actions[bot] avatar Nov 22 '25 22:11 github-actions[bot]

Hi, I'm a first-time contributor.
Could someone please approve the workflows so CI can run?
Also, let me know if I need to fix anything from my side. Thank you!

Arunodoy18 avatar Nov 23 '25 16:11 Arunodoy18

assign set of reviewers

Arunodoy18 avatar Nov 29 '25 08:11 Arunodoy18

Assigning reviewers:

R: @Abacn for label java.

Note: If you would like to opt out of this review, comment assign to next reviewer.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

github-actions[bot] avatar Nov 29 '25 08:11 github-actions[bot]

Reminder, please take a look at this pr: @Abacn

github-actions[bot] avatar Dec 06 '25 12:12 github-actions[bot]

Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment assign to next reviewer:

R: @chamikaramj for label java.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

github-actions[bot] avatar Dec 10 '25 12:12 github-actions[bot]

Reminder, please take a look at this pr: @chamikaramj

github-actions[bot] avatar Dec 18 '25 12:12 github-actions[bot]