beam icon indicating copy to clipboard operation
beam copied to clipboard

Add environment variable for skipping slow ensure_clean_state python fixture

Open hjtran opened this issue 2 months ago • 4 comments

The ensure_clean_state pytest fixture adds ~200ms of overhead to every unit test. This slows down local development quite a bit.

This adds an opt-in environment flag to skip this fixture which lets local development go a bit faster while still allowing the fixture to run on the GH runners and reduce the amount of intermittent failures.

With this, the decorators_test takes 3s instead of 12s on my machine.

  • [ ] Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • [ ] Update CHANGES.md with noteworthy changes.
  • [ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)


Build python source distribution and wheels Python tests Java tests Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

hjtran avatar Oct 06 '25 10:10 hjtran

Summary of Changes

Hello @hjtran, I'm Gemini Code Assist[^1]! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request aims to enhance the local development experience for Python contributors by providing a mechanism to accelerate test execution. It introduces an opt-in environment variable that allows developers to bypass a specific pytest fixture, ensure_clean_state, which is known to introduce significant overhead during local runs. This optimization is designed to speed up iterative development cycles without compromising the integrity or thoroughness of tests executed in continuous integration environments.

Highlights

  • Test Performance Improvement: Introduces an environment variable to optionally skip the ensure_clean_state pytest fixture.
  • Local Development Speed-up: This change significantly reduces test execution time for local development, as the fixture adds ~200ms overhead per test, potentially speeding up test suites like decorators_test from 12s to 3s.
  • CI Integrity Maintained: The fixture will continue to run on GitHub CI runners, ensuring test stability and reducing intermittent failures in the official build process.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with :thumbsup: and :thumbsdown: on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

[^1]: Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

gemini-code-assist[bot] avatar Oct 06 '25 10:10 gemini-code-assist[bot]

R: @shunping @A1K28

failures look unrelated

hjtran avatar Oct 06 '25 12:10 hjtran

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment assign set of reviewers

github-actions[bot] avatar Oct 06 '25 12:10 github-actions[bot]

This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the [email protected] list. Thank you for your contributions.

github-actions[bot] avatar Dec 05 '25 12:12 github-actions[bot]

This pull request has been closed due to lack of activity. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.

github-actions[bot] avatar Dec 12 '25 12:12 github-actions[bot]