beam icon indicating copy to clipboard operation
beam copied to clipboard

Add Apache Iceberg support and Catalog support to Beam SQL documentation

Open talatuyarer opened this issue 3 months ago • 7 comments

This PR adds documentation for Apache Iceberg support in Beam SQL, including both new catalog management.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • [ ] Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • [ ] Update CHANGES.md with noteworthy changes.
  • [ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels Python tests Java tests Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

talatuyarer avatar Sep 30 '25 07:09 talatuyarer

Summary of Changes

Hello @talatuyarer, I'm Gemini Code Assist[^1]! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the Beam SQL documentation by introducing comprehensive guides for integrating with Apache Iceberg. It covers the new CREATE CATALOG statement for managing external data sources via Iceberg catalogs and extends the CREATE EXTERNAL TABLE documentation to include Iceberg and DataGen types, providing users with detailed instructions and examples for leveraging Iceberg's capabilities within Beam SQL.

Highlights

  • New CREATE CATALOG Documentation: A new documentation page has been added for the CREATE CATALOG statement in Beam SQL, specifically detailing its use for Apache Iceberg catalogs. This includes syntax, properties, examples, and best practices for catalog management.
  • Enhanced CREATE EXTERNAL TABLE Documentation: The CREATE EXTERNAL TABLE documentation has been updated to include support for iceberg and datagen table types. A comprehensive section on Apache Iceberg tables covers syntax, partitioning, read/write modes, schema mapping, and various examples.
  • Apache Iceberg Integration: The changes provide detailed guidance on how to leverage Apache Iceberg's features, such as ACID transactions, schema evolution, and time travel, directly within Beam SQL through both catalog and external table definitions.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with :thumbsup: and :thumbsdown: on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

[^1]: Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

gemini-code-assist[bot] avatar Sep 30 '25 07:09 gemini-code-assist[bot]

@ahmedabu98 please review this

talatuyarer avatar Sep 30 '25 07:09 talatuyarer

Assigning reviewers:

R: @damccorm for label website.

Note: If you would like to opt out of this review, comment assign to next reviewer.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

github-actions[bot] avatar Sep 30 '25 08:09 github-actions[bot]

R: @ahmedabu98

damccorm avatar Sep 30 '25 14:09 damccorm

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment assign set of reviewers

github-actions[bot] avatar Sep 30 '25 14:09 github-actions[bot]

This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the [email protected] list. Thank you for your contributions.

github-actions[bot] avatar Nov 30 '25 12:11 github-actions[bot]

@ahmedabu98 could you please take a look?

damccorm avatar Dec 01 '25 20:12 damccorm