try buildah to replace kaniko
fixes #35269
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] Mention the appropriate issue in your description (for example:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead. - [ ] Update
CHANGES.mdwith noteworthy changes. - [ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.
See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.
Assigning reviewers:
R: @damccorm for label python.
Note: If you would like to opt out of this review, comment assign to next reviewer.
Available commands:
stop reviewer notifications- opt out of the automated review toolingremind me after tests pass- tag the comment author after tests passwaiting on author- shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
Thanks - this looks like a good change, but I'd like to get a little more test coverage on the PR. I think https://github.com/apache/beam/blob/e51461a22617ef868e572709927ab48300e44c07/sdks/python/apache_beam/examples/wordcount_it_test.py#L93 should test this and run as part of https://github.com/apache/beam/blob/master/.github/workflows/beam_PostCommit_Python_ValidatesContainer_Dataflow.yml .
Could you trigger that workflow by modifying https://github.com/apache/beam/blob/master/.github/trigger_files/beam_PostCommit_Python_ValidatesContainer_Dataflow.json and pushing it?
https://github.com/apache/beam/blob/master/.github/trigger_files/beam_PostCommit_Python_ValidatesContainer_Dataflow.json
Good idea. Thanks!
Looks like the workflow is broken by a dep change right now. We should be able to fix with https://github.com/apache/beam/pull/35305 then we can merge that branch in here and rerun the checks