beam icon indicating copy to clipboard operation
beam copied to clipboard

feat: Add option to control resource cleanup failure for IT

Open liferoad opened this issue 6 months ago • 1 comments

Adds a failOnCleanup parameter to the cleanResources method in ResourceManagerUtils, allowing callers to specify whether an exception should be thrown when resource cleanup fails.

This provides more control over the test failure behavior, with the default set to false to avoid throwing exceptions on cleanup failures.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • [ ] Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • [ ] Update CHANGES.md with noteworthy changes.
  • [ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels Python tests Java tests Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

liferoad avatar Jun 14 '25 15:06 liferoad

Assigning reviewers:

R: @robertwb added as fallback since no labels match configuration

Note: If you would like to opt out of this review, comment assign to next reviewer.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

github-actions[bot] avatar Jun 14 '25 16:06 github-actions[bot]