beam icon indicating copy to clipboard operation
beam copied to clipboard

Iobase streaming support in FileBasedSink, exposed in TextIO

Open razvanculea opened this issue 6 months ago • 1 comments

FUP to https://github.com/apache/beam/pull/35137

FileBasedSink :

  • implement pre_finalize_windowed and finalize_windowed_write
  • handle file naming based on windowing for streaming in internal methods

TextIO - expose the new filebasedsink capabilities to write in streaming


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • [ ] Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • [ ] Update CHANGES.md with noteworthy changes.
  • [ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels Python tests Java tests Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

razvanculea avatar Jun 12 '25 09:06 razvanculea

Assigning reviewers:

R: @claudevdm for label python.

Note: If you would like to opt out of this review, comment assign to next reviewer.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

github-actions[bot] avatar Jun 12 '25 10:06 github-actions[bot]

Run Python_Examples PreCommit 3.9

razvanculea avatar Jun 17 '25 14:06 razvanculea

Run Python_Examples PreCommit 3.9

razvanculea avatar Jun 17 '25 15:06 razvanculea

Run Python_Examples PreCommit 3.9

razvanculea avatar Jun 17 '25 19:06 razvanculea

Run Python_Examples PreCommit 3.9

razvanculea avatar Jun 23 '25 11:06 razvanculea

Run Python_Examples PreCommit 3.9

razvanculea avatar Jun 24 '25 08:06 razvanculea

Reminder, please take a look at this pr: @claudevdm

github-actions[bot] avatar Jul 01 '25 12:07 github-actions[bot]

Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment assign to next reviewer:

R: @shunping for label python.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

github-actions[bot] avatar Jul 04 '25 12:07 github-actions[bot]

Reminder, please take a look at this pr: @shunping

github-actions[bot] avatar Jul 11 '25 12:07 github-actions[bot]

Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment assign to next reviewer:

R: @damccorm for label python.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

github-actions[bot] avatar Jul 16 '25 12:07 github-actions[bot]

R: @shunping - keeping this sticky since Shunping also has context from the last PR

damccorm avatar Jul 16 '25 13:07 damccorm

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment assign set of reviewers

github-actions[bot] avatar Jul 16 '25 13:07 github-actions[bot]

@shunping could you please take a look?

damccorm avatar Jul 25 '25 13:07 damccorm

waiting on author

shunping avatar Jul 28 '25 17:07 shunping

Run Python_Coverage PreCommit

razvanculea avatar Jul 30 '25 11:07 razvanculea

@razvanculea, this looks great! The test failures of ML seem irrelevant to this change.

shunping avatar Jul 30 '25 13:07 shunping