beam icon indicating copy to clipboard operation
beam copied to clipboard

Fix nullness for schemas/logicaltypes

Open kennknowles opened this issue 6 months ago • 5 comments

While reviewing code touching this, it seemed like having the files annotated and analysis active would be helpful.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • [x] Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • [x] Update CHANGES.md with noteworthy changes.
  • [x] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels Python tests Java tests Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

kennknowles avatar Jun 09 '25 18:06 kennknowles

R: @baeminbo

kennknowles avatar Jun 09 '25 18:06 kennknowles

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment assign set of reviewers

github-actions[bot] avatar Jun 09 '25 18:06 github-actions[bot]

I cannot reproduce the failure in the precommit locally - I believe it is a flake. Please do review while I kick the tests repeatedly.

kennknowles avatar Jun 10 '25 21:06 kennknowles

You could also just cherrypick the commit onto your PR (and reorder the commits however you want). That might be the simplest thing to do.

kennknowles avatar Jun 10 '25 21:06 kennknowles

I cherry-picked the commit to https://github.com/apache/beam/pull/35150

baeminbo avatar Jun 11 '25 00:06 baeminbo