apache
add streaming support to iobase (python)
iobase.Sink has 2 new methods to be implemented for writing in streaming pipelines.
- pre_finalize_windowed
- finalize_windowed_write These methods are aware of the window and can handle finalization per window (ex: to name files per window and avoid collisions of the filesystem)
Add to WriteImpl the implementation for streaming writes:
- GlobalWindow, Sink.triggering_frequency is needed and the WriteImpl adds a rewindowing into Fixed Windows of the size of triggering_frequency
- Windowed PCollection, existing windowing is used unless overridden by triggering_frequency (>0)
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] Mention the appropriate issue in your description (for example:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead. - [ ] Update
CHANGES.mdwith noteworthy changes. - [ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.
See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
Assigning reviewers:
R: @tvalentyn for label python.
Note: If you would like to opt out of this review, comment assign to next reviewer.
Available commands:
stop reviewer notifications- opt out of the automated review toolingremind me after tests pass- tag the comment author after tests passwaiting on author- shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
Stopping reviewer notifications for this pull request: requested by reviewer. If you'd like to restart, comment assign set of reviewers
FYI this PR will be followed up by https://github.com/apache/beam/pull/35253 , to implement the changes in FileBasedSink and expose them in TextIO
Another PR will be made for Avro/Parquet/TFrecords IOs