apache
Add filter to GetMinUnfinishedWatermark queryAdd filter tester
To improve the performance of the query for GetUnfinishedMinWatermark, we can add a filter to the query. Note that the query run on a cache to refresh every 1s. We can remember the cached value every time and use the value as a filter in the next time query.
Integration test can pass locally https://screenshot.googleplex.com/6aQBPAW8YT69VTd
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
Run integration test locally based on earlier commit https://github.com/apache/beam/pull/34883 and it passed. Hence the integration timeout is not caused by this PR.
Assigning reviewers:
R: @m-trieu for label java. R: @nielm for label spanner.
Note: If you would like to opt out of this review, comment assign to next reviewer.
Available commands:
stop reviewer notifications- opt out of the automated review toolingremind me after tests pass- tag the comment author after tests passwaiting on author- shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment assign to next reviewer:
R: @chamikaramj for label java. R: @nielm for label spanner.
Available commands:
stop reviewer notifications- opt out of the automated review toolingremind me after tests pass- tag the comment author after tests passwaiting on author- shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
It seems GCP IO integration test stucks indefinitely. Retriggered the test
update: second try still stuck, retriggering
If it timeouts for the third time, consider add class level test timeout for integraton tests that might be affected to debug
