beam icon indicating copy to clipboard operation
beam copied to clipboard

Add checkpoint during progress reporting.

Open shunping opened this issue 7 months ago • 10 comments

addresses #33815

I verified that the previous stuck sample code in https://github.com/apache/beam/issues/33815#issue-2821229417 and https://github.com/apache/beam/issues/33815#issuecomment-2844032012 is working with this PR's changes.

shunping avatar May 03 '25 03:05 shunping

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @jrmccluskey for label go.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

github-actions[bot] avatar May 03 '25 04:05 github-actions[bot]

Reminder, please take a look at this pr: @jrmccluskey

github-actions[bot] avatar May 13 '25 12:05 github-actions[bot]

Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment assign to next reviewer:

R: @lostluck for label go.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

github-actions[bot] avatar May 16 '25 12:05 github-actions[bot]

waiting on author

shunping avatar May 16 '25 12:05 shunping

Assign that back to me as I need to make some more changes.

shunping avatar May 16 '25 12:05 shunping

Reminder, please take a look at this pr: @lostluck

github-actions[bot] avatar May 24 '25 12:05 github-actions[bot]

Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment assign to next reviewer:

R: @jrmccluskey for label go.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

github-actions[bot] avatar May 28 '25 12:05 github-actions[bot]

Converting this back to draft for now as it needs some more thoughts.

shunping avatar Jun 02 '25 12:06 shunping

Reminder, please take a look at this pr: @jrmccluskey

github-actions[bot] avatar Jun 10 '25 12:06 github-actions[bot]

Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment assign to next reviewer:

R: @lostluck for label go.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

github-actions[bot] avatar Jun 13 '25 12:06 github-actions[bot]

Reminder, please take a look at this pr: @lostluck

github-actions[bot] avatar Jun 20 '25 12:06 github-actions[bot]

waiting on author

(since the bot doesn't know how drafts work)

lostluck avatar Jun 23 '25 20:06 lostluck

waiting on author

derrickaw avatar Aug 06 '25 17:08 derrickaw

It is a draft PR, and I don't have bandwidth to move forward with that recently. Feel free to close it if the bot is making too much noise.

shunping avatar Aug 07 '25 01:08 shunping

Reminder, please take a look at this pr: @lostluck

github-actions[bot] avatar Aug 14 '25 12:08 github-actions[bot]

Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment assign to next reviewer:

R: @jrmccluskey for label go.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

github-actions[bot] avatar Aug 19 '25 12:08 github-actions[bot]

The place in the center

danowar2 avatar Aug 19 '25 12:08 danowar2

Closing this for now.

shunping avatar Aug 19 '25 12:08 shunping