beam icon indicating copy to clipboard operation
beam copied to clipboard

Fn Runner Watermark issue

Open 13MaxG opened this issue 9 months ago • 5 comments

Proposing a solution to https://github.com/apache/beam/issues/26190 . It appears the Flatten was not setting a watermark, which caused following steps not to execute.

The issue was returning errors on beam versions 2.39 onwards, and it potentially produced unstable results before 2.39.

There are meaningful TODOs mentioned: # TODO(robertwb): Possibly fuse multi-input flattens into one of the stages. # TODO(pabloem): Consider case where there are various producers

13MaxG avatar Mar 31 '25 09:03 13MaxG

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

github-actions[bot] avatar Mar 31 '25 11:03 github-actions[bot]

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @claudevdm for label python. R: @damccorm for label build.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

github-actions[bot] avatar Apr 01 '25 15:04 github-actions[bot]

Reminder, please take a look at this pr: @claudevdm @damccorm

github-actions[bot] avatar Apr 11 '25 12:04 github-actions[bot]

waiting on author

damccorm avatar Apr 11 '25 14:04 damccorm

This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the [email protected] list. Thank you for your contributions.

github-actions[bot] avatar Jun 11 '25 12:06 github-actions[bot]

This pull request has been closed due to lack of activity. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.

github-actions[bot] avatar Jun 18 '25 12:06 github-actions[bot]