beam icon indicating copy to clipboard operation
beam copied to clipboard

Concat protos in BQStorageWriteAPI - solve edge cases during mering of nested repeated fields

Open stankiewicz opened this issue 9 months ago • 17 comments

BQStorageWriteAPI concatenates proto payload with unknown fields to support schema update. today concat is naive and won't work correctly for repeated structs. This change introduces expensive merging only when Beam has to merge repeated struct.

#34145

stankiewicz avatar Mar 26 '25 14:03 stankiewicz

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

github-actions[bot] avatar Mar 27 '25 17:03 github-actions[bot]

Run Java_GCP_IO_Direct PreCommit

stankiewicz avatar Mar 27 '25 19:03 stankiewicz

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @m-trieu for label java. R: @shunping for label io.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

github-actions[bot] avatar Mar 27 '25 21:03 github-actions[bot]

Reminder, please take a look at this pr: @m-trieu @shunping

github-actions[bot] avatar Apr 04 '25 12:04 github-actions[bot]

Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment assign to next reviewer:

R: @Abacn for label java. R: @shunping for label io.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

github-actions[bot] avatar Apr 08 '25 12:04 github-actions[bot]

Reminder, please take a look at this pr: @Abacn @shunping

github-actions[bot] avatar Apr 16 '25 12:04 github-actions[bot]

Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment assign to next reviewer:

R: @ahmedabu98 for label java. R: @shunping for label io.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

github-actions[bot] avatar Apr 21 '25 12:04 github-actions[bot]

Reminder, please take a look at this pr: @ahmedabu98 @shunping

github-actions[bot] avatar Apr 28 '25 12:04 github-actions[bot]

Hi @stankiewicz, what is the status of this PR?

Abacn avatar Apr 28 '25 18:04 Abacn

Reminder, please take a look at this pr: @ahmedabu98 @shunping

github-actions[bot] avatar May 06 '25 12:05 github-actions[bot]

Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment assign to next reviewer:

R: @chamikaramj for label java. R: @shunping for label io.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

github-actions[bot] avatar May 09 '25 12:05 github-actions[bot]

Reminder, please take a look at this pr: @chamikaramj @shunping

github-actions[bot] avatar May 16 '25 12:05 github-actions[bot]

Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment assign to next reviewer:

R: @robertwb for label java. R: @shunping for label io.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

github-actions[bot] avatar May 21 '25 12:05 github-actions[bot]

Reminder, please take a look at this pr: @robertwb @shunping

github-actions[bot] avatar May 28 '25 12:05 github-actions[bot]

Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment assign to next reviewer:

R: @ahmedabu98 for label java. R: @shunping for label io.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

github-actions[bot] avatar Jun 02 '25 12:06 github-actions[bot]

Reminder, please take a look at this pr: @ahmedabu98 @shunping

github-actions[bot] avatar Jun 10 '25 12:06 github-actions[bot]

Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment assign to next reviewer:

R: @Abacn for label java. R: @shunping for label io.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

github-actions[bot] avatar Jun 13 '25 12:06 github-actions[bot]

Reminder, please take a look at this pr: @Abacn @shunping

github-actions[bot] avatar Jun 20 '25 12:06 github-actions[bot]

Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment assign to next reviewer:

R: @ahmedabu98 for label java. R: @shunping for label io.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

github-actions[bot] avatar Jun 24 '25 12:06 github-actions[bot]

Reminder, please take a look at this pr: @ahmedabu98 @shunping

github-actions[bot] avatar Jul 02 '25 12:07 github-actions[bot]

Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment assign to next reviewer:

R: @robertwb for label java. R: @shunping for label io.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

github-actions[bot] avatar Jul 07 '25 12:07 github-actions[bot]

Reminder, please take a look at this pr: @robertwb @shunping

github-actions[bot] avatar Jul 14 '25 12:07 github-actions[bot]

cc: @ahmedabu98

Abacn avatar Jul 14 '25 19:07 Abacn

Reminder, please take a look at this pr: @robertwb @shunping

github-actions[bot] avatar Jul 22 '25 12:07 github-actions[bot]

Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment assign to next reviewer:

R: @Abacn for label java. R: @shunping for label io.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

github-actions[bot] avatar Jul 24 '25 12:07 github-actions[bot]

Reminder, please take a look at this pr: @Abacn @shunping

github-actions[bot] avatar Aug 01 '25 12:08 github-actions[bot]

Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment assign to next reviewer:

R: @robertwb for label java. R: @shunping for label io.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

github-actions[bot] avatar Aug 05 '25 12:08 github-actions[bot]

Hi @shunping and @robertwb, please review when you get a chance. Thanks!

derrickaw avatar Aug 12 '25 14:08 derrickaw

Reminder, please take a look at this pr: @robertwb @shunping

github-actions[bot] avatar Aug 20 '25 12:08 github-actions[bot]

Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment assign to next reviewer:

R: @Abacn for label java. R: @shunping for label io.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

github-actions[bot] avatar Aug 25 '25 12:08 github-actions[bot]