beam icon indicating copy to clipboard operation
beam copied to clipboard

feat:large-row-skip-in-bigtable | added experimental options to skip …

Open sarthakbhutani opened this issue 9 months ago • 13 comments

…large rows while reading from bigtable

Please add a meaningful description for your change here


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • [ ] Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • [ ] Update CHANGES.md with noteworthy changes.
  • [ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels Python tests Java tests Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

sarthakbhutani avatar Mar 11 '25 10:03 sarthakbhutani

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

github-actions[bot] avatar Mar 11 '25 10:03 github-actions[bot]

Retest this please

chamikaramj avatar Mar 27 '25 22:03 chamikaramj

not sure why spotless check is failing - this is related to code formatting. Working fine on local.

image

sarthakbhutani avatar Apr 22 '25 10:04 sarthakbhutani

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @Abacn for label java. R: @djyau for label bigtable.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

github-actions[bot] avatar Apr 22 '25 12:04 github-actions[bot]

Reminder, please take a look at this pr: @Abacn @djyau

github-actions[bot] avatar May 03 '25 12:05 github-actions[bot]

Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment assign to next reviewer:

R: @robertwb for label java. R: @johnjcasey for label bigtable.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

github-actions[bot] avatar May 07 '25 12:05 github-actions[bot]

Reminder, please take a look at this pr: @robertwb @johnjcasey

github-actions[bot] avatar May 15 '25 12:05 github-actions[bot]

Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment assign to next reviewer:

R: @Abacn for label java. R: @jrmccluskey for label bigtable.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

github-actions[bot] avatar May 19 '25 12:05 github-actions[bot]

I was occupied with other work, hence, couldn't take this up earlier. It is already reviewed, I'll be proceeding with feedback incorporation now.

sarthakbhutani avatar May 20 '25 11:05 sarthakbhutani

Reminder, please take a look at this pr: @Abacn @jrmccluskey

github-actions[bot] avatar May 27 '25 12:05 github-actions[bot]

Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment assign to next reviewer:

R: @robertwb for label java. R: @kennknowles for label bigtable.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

github-actions[bot] avatar May 30 '25 12:05 github-actions[bot]

Reminder, please take a look at this pr: @robertwb @kennknowles

github-actions[bot] avatar Jun 07 '25 12:06 github-actions[bot]

Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment assign to next reviewer:

R: @Abacn for label java. R: @liferoad for label bigtable.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

github-actions[bot] avatar Jun 11 '25 12:06 github-actions[bot]

Reminder, please take a look at this pr: @Abacn @liferoad

github-actions[bot] avatar Jun 19 '25 12:06 github-actions[bot]

stop reviewer notification

liferoad avatar Jun 19 '25 14:06 liferoad

Reminder, please take a look at this pr: @Abacn @liferoad

github-actions[bot] avatar Jun 27 '25 12:06 github-actions[bot]

waiting on author

liferoad avatar Jun 27 '25 13:06 liferoad

waiting on author

derrickaw avatar Aug 12 '25 14:08 derrickaw

This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the [email protected] list. Thank you for your contributions.

github-actions[bot] avatar Oct 12 '25 12:10 github-actions[bot]

This pull request has been closed due to lack of activity. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.

github-actions[bot] avatar Oct 19 '25 12:10 github-actions[bot]