beam icon indicating copy to clipboard operation
beam copied to clipboard

Upgrade GCP-BOM to 26.49.0

Open Abacn opened this issue 1 year ago • 3 comments

Please add a meaningful description for your change here


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • [ ] Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • [ ] Update CHANGES.md with noteworthy changes.
  • [ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels Python tests Java tests Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

Abacn avatar Oct 18 '24 15:10 Abacn

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

github-actions[bot] avatar Oct 18 '24 17:10 github-actions[bot]

Many zetasql nexmark tests fails with

com.google.zetasql.io.grpc.StatusRuntimeException: UNKNOWN
	at com.google.zetasql.io.grpc.stub.ClientCalls.toStatusRuntimeException(ClientCalls.java:262)
	at com.google.zetasql.io.grpc.stub.ClientCalls.getUnchecked(ClientCalls.java:243)
	at com.google.zetasql.io.grpc.stub.ClientCalls.blockingUnaryCall(ClientCalls.java:156)
	at com.google.zetasql.ZetaSqlLocalServiceGrpc$ZetaSqlLocalServiceBlockingStub.getLanguageOptions(ZetaSqlLocalServiceGrpc.java:1562)
...
Caused by: java.lang.UnsupportedOperationException
	at com.google.zetasql.io.grpc.netty.AbstractHttp2Headers.iterator(AbstractHttp2Headers.java:500)
	at io.netty.handler.codec.http2.DefaultHttp2ConnectionDecoder$FrameReadListener.onHeadersRead(DefaultHttp2ConnectionDecoder.java:423)

due to netty_version bumped from "4.1.100.Final" to "4.1.110.Final", not compatible with zetasql "2022.04.1" shaded netty version

Similar to https://github.com/grpc/grpc-java/issues/10707

Abacn avatar Oct 18 '24 21:10 Abacn

as of the latest version of zetasql-client: https://mvnrepository.com/artifact/com.google.zetasql/zetasql-client/2024.08.2

it still shades grpc-1.56.0 and io.netty 4.1.87.Final (last updated: 2023.08.1)

Abacn avatar Oct 18 '24 21:10 Abacn

testCommit_handlesFailedCommits (org.apache.beam.runners.dataflow.worker.windmill.client.commits.StreamingEngineWorkCommitterTest) failed


expected to contain: CompleteCommit{computationId=computationId-10, shardedKey=0000000000000002, workId=WorkId{cacheToken=1, workToken=10}, status=ABORTED}
but was            : [CompleteCommit{computationId=computationId-6, shardedKey=0000000000000002, ...

not related to this change. Same test passed the first attempt run (where other irrelevant test failed)

Abacn avatar Nov 20 '24 21:11 Abacn

R: @damccorm

Abacn avatar Nov 20 '24 21:11 Abacn

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment assign set of reviewers

github-actions[bot] avatar Nov 20 '24 21:11 github-actions[bot]