Support poisioning instruction ids to prevent the FnApi data stream from blocking on failed instructions
Previously it could occur that an instruction id was observed on the control stream but due to exception it would never register a handler and the data stream would be forever blocked trying to multiplex elements to it's queue.
Fixes #32714
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] Mention the appropriate issue in your description (for example:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead. - [ ] Update
CHANGES.mdwith noteworthy changes. - [ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.
See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers
Test failures appear to be unrelated flakiness
assign set of reviewers
Run Java PreCommit
Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:
R: @robertwb for label java.
Available commands:
stop reviewer notifications- opt out of the automated review toolingremind me after tests pass- tag the comment author after tests passwaiting on author- shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 58.95%. Comparing base (
1e27978) to head (abc5492). Report is 121 commits behind head on master.
Additional details and impacted files
@@ Coverage Diff @@
## master #32857 +/- ##
============================================
+ Coverage 57.41% 58.95% +1.53%
- Complexity 1475 3112 +1637
============================================
Files 968 1131 +163
Lines 154224 174787 +20563
Branches 1076 3357 +2281
============================================
+ Hits 88546 103038 +14492
- Misses 63477 68398 +4921
- Partials 2201 3351 +1150
| Flag | Coverage Δ | |
|---|---|---|
| java | 69.94% <ø> (+1.35%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Run Java PreCommit
Run Java_IOs_Direct PreCommit
Run Java_Pulsar_IO_Direct PreCommit
Run Java_IOs_Direct PreCommit
Run Java_Hadoop_IO_Direct PreCommit
Run Java PreCommit
Run Java_Hadoop_IO_Direct PreCommit
(removed, commented on wrong issue)
Run Java PreCommit
Run Java_IOs_Direct PreCommit
Run Java_Pulsar_IO_Direct PreCommit
Run Java PreCommit
Run Java_IOs_Direct PreCommit
precommit failures were unrelated flakes in :runners:google-cloud-dataflow-java:worker:test