beam icon indicating copy to clipboard operation
beam copied to clipboard

Simplify budget distribution logic and new worker metadata consumption

Open m-trieu opened this issue 1 year ago • 2 comments

Remove the budget distributor thread and move the managing of each server's internal budget to the direct GetWorkStream.

R: @arunpandianp @scwhittle


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • [ ] Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • [ ] Update CHANGES.md with noteworthy changes.
  • [ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels Python tests Java tests Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

m-trieu avatar Oct 14 '24 22:10 m-trieu

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @shunping added as fallback since no labels match configuration

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

github-actions[bot] avatar Oct 14 '24 23:10 github-actions[bot]

back to you @scwhittle Thanks!

m-trieu avatar Oct 17 '24 13:10 m-trieu

thanks @scwhittle ! back to you

m-trieu avatar Oct 21 '24 03:10 m-trieu

Run Java PreCommit

scwhittle avatar Oct 21 '24 08:10 scwhittle

It seems "FanOutStreamingEngineWorkerHarnessTest" becomes increasingly flaky recently, e.g. on schedule run:

https://github.com/apache/beam/runs/32620998299

and on a PR run:

https://github.com/apache/beam/runs/32622849052

error:

java.lang.AssertionError
	at org.junit.Assert.fail(Assert.java:87)
	at org.junit.Assert.assertTrue(Assert.java:42)
	at org.junit.Assert.assertTrue(Assert.java:53)
	at org.apache.beam.runners.dataflow.worker.streaming.harness.FanOutStreamingEngineWorkerHarnessTest.testStreamsStartCorrectly(FanOutStreamingEngineWorkerHarnessTest.java:217)

Abacn avatar Nov 07 '24 03:11 Abacn