beam icon indicating copy to clipboard operation
beam copied to clipboard

[Bug]: vendored jars leak proto

Open Abacn opened this issue 1 year ago • 2 comments

What happened?

Beam vendors a few dependencies (grpc, guava). These vendored dependency jars have package namespace shaded (* -> org/apache/beam/vendor/*) so it won't leak classes. However this repackage does not contain protos, as a result, it still leaks proto sources

For example, in org.apache.beam » beam-vendor-grpc-1_60_1 » 0.2:

beam-vendor-grpc-1_60_1-0.2
|-grpc
|  |-google
|  |  |-api
|  |  |  |-field_behavior.proto
...

Protobuf error

@zhumin8 created a reproducer with Protobuf Gradle plugin where it gets protoc: stdout: . stderr: sample.proto:6:52: Enum type "google.api.FieldBehavior" has no value named "IDENTIFIER" for option "google.api.field_behavior":

https://github.com/zhumin8/cloud-opensource-java/tree/test/boms/test-gradle

Issue Priority

Priority: 2 (default / most bugs should be filed as P2)

Issue Components

  • [ ] Component: Python SDK
  • [X] Component: Java SDK
  • [ ] Component: Go SDK
  • [ ] Component: Typescript SDK
  • [ ] Component: IO connector
  • [ ] Component: Beam YAML
  • [ ] Component: Beam examples
  • [ ] Component: Beam playground
  • [ ] Component: Beam katas
  • [ ] Component: Website
  • [ ] Component: Infrastructure
  • [ ] Component: Spark Runner
  • [ ] Component: Flink Runner
  • [ ] Component: Samza Runner
  • [ ] Component: Twister2 Runner
  • [ ] Component: Hazelcast Jet Runner
  • [ ] Component: Google Cloud Dataflow Runner

Abacn avatar Oct 11 '24 19:10 Abacn

marked as 2.62.0 release blocker (cut on Dec 18, 2024)

Abacn avatar Oct 11 '24 20:10 Abacn

Added "Protobuf error" section in the description.

suztomo avatar Oct 11 '24 20:10 suztomo