beam icon indicating copy to clipboard operation
beam copied to clipboard

Update the python deps caused by numpy 2.0

Open liferoad opened this issue 1 year ago • 2 comments

Addresses https://github.com/apache/beam/issues/32681

Following https://cwiki.apache.org/confluence/display/BEAM/Python+Tips#PythonTips-HowtoupdatedependenciesthatareinstalledinPythoncontainerimages and https://cwiki.apache.org/confluence/display/BEAM/Python+Tips#PythonTips-InstallingPythoninterpreters, updated the base image deps.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • [ ] Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • [ ] Update CHANGES.md with noteworthy changes.
  • [ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels Python tests Java tests Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

liferoad avatar Oct 11 '24 18:10 liferoad

cc @jrmccluskey

liferoad avatar Oct 11 '24 18:10 liferoad

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @damccorm for label python.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

github-actions[bot] avatar Oct 11 '24 19:10 github-actions[bot]

Reminder, please take a look at this pr: @damccorm

github-actions[bot] avatar Oct 23 '24 12:10 github-actions[bot]

We will pin protobuf==4.25.5 for now with Beam 2.61.0.

liferoad avatar Oct 23 '24 13:10 liferoad

cc @Abacn later I will polish this PR to update the deps. FYI.

liferoad avatar Oct 23 '24 13:10 liferoad

Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment assign to next reviewer:

R: @tvalentyn for label python.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

github-actions[bot] avatar Oct 28 '24 12:10 github-actions[bot]

stop reviewer notifications

liferoad avatar Oct 28 '24 13:10 liferoad

Stopping reviewer notifications for this pull request: requested by reviewer. If you'd like to restart, comment assign set of reviewers

github-actions[bot] avatar Oct 28 '24 13:10 github-actions[bot]

Given how close we are to the release cut, I would keep the dependency changes to a minimum or do this update after the release cut.

tvalentyn avatar Oct 30 '24 20:10 tvalentyn

For example, if there is a regression in google-api-core==2.22.0, we have only two weeks to notice that.

tvalentyn avatar Oct 30 '24 20:10 tvalentyn

@damccorm what do you think? I am fine to do this after 2.61.0.

liferoad avatar Oct 30 '24 20:10 liferoad

Its borderline, but I probably agree waiting is safer. I don't think we need to do this for the current release

damccorm avatar Oct 30 '24 21:10 damccorm

Rebased. Based on the discussions, we should get this in ASAP after 2.61.0.

liferoad avatar Nov 15 '24 17:11 liferoad

https://github.com/apache/beam/actions/workflows/beam_PreCommit_Python_Coverage.yml, https://github.com/apache/beam/actions/workflows/beam_PreCommit_Python_ML.yml, are also read on the master. My PR is not related to these failed workflows.

liferoad avatar Nov 15 '24 19:11 liferoad